[MPlayer-dev-eng] [PATCH] real demuxer fix V3

Balatoni Denes pnis at coder.hu
Wed Feb 12 21:56:52 CET 2003


On 2003. február 12. 21:45, Arpi wrote:
> Hi,
>
> > +    if( ( ( s[0] & (~0xf) ) ==0 ) || ( ( s[0] & (~0xf) ) ==0x40 ) ||
> > +	( ( s[0] & (~0xf) ) ==0x50 ) || ( ( s[0] & (~0x7) ) ==0x10 ) ){
>
> is this a typo, and should be 0xf ? -----------------^^^
no type 18-1f : it has normal timestamp
10-17: it uses previous keyframe's(?) timestamp
all rv30 streams use them , rv40 uses 0x4q and 06r 0x7s and perhaps others

> if no, could you tell me which stream requires 0x7 ?
>
> anyway i think this if() should be split, depending on codec (fourcc),
> it seems the picture type bits are at different positions.
looks clean to me, but tell me what you think should be split for acceptance 
of the patch

bye
Denes

ps: I downloaded realplayer9&8 and they both play rv30 streams with the same
a-v sync as mplayer (including a141.rm). And the no_video.rm can not be played 
with rp1 (mplayer plays the music well :) ). rv40 sync is also correct, only 
these cuts in the image should disappear sooner or later. rv20&rv10 sync 
needs to be improved. And for some reason rp1&8 wouldn't play the pnm:// 
stream dumps, which mplayer can play of course. So it seems real1 has room to 
improve :]




More information about the MPlayer-dev-eng mailing list