[MPlayer-dev-eng] [PATCH] real demuxer fix V3

[Arpi]

Hi,

> > > +    if( ( ( s[0] & (~0xf) ) ==0 ) || ( ( s[0] & (~0xf) ) ==0x40 ) ||
> > > +	( ( s[0] & (~0xf) ) ==0x50 ) || ( ( s[0] & (~0x7) ) ==0x10 ) ){
> >
> > is this a typo, and should be 0xf ? -----------------^^^
> no type 18-1f : it has normal timestamp
> 10-17: it uses previous keyframe's(?) timestamp

nice, it matches what i found (my code was if( !(s&0x10) || !(s&8) ))

> all rv30 streams use them , rv40 uses 0x4q and 06r 0x7s and perhaps others

you mean 0x4? 0x6? and 0x7? are B frames and the rest (0x(0..3)? and 0x5?
are I/P ?)

> > if no, could you tell me which stream requires 0x7 ?
> >
> > anyway i think this if() should be split, depending on codec (fourcc),
> > it seems the picture type bits are at different positions.
> looks clean to me, but tell me what you think should be split for acceptance 
> of the patch

at least the I/P vs. B decision

> ps: I downloaded realplayer9&8 and they both play rv30 streams with the same
> a-v sync as mplayer (including a141.rm). And the no_video.rm can not be played 
> with rp1 (mplayer plays the music well :) ). rv40 sync is also correct, only 
> these cuts in the image should disappear sooner or later. rv20&rv10 sync 
> needs to be improved. And for some reason rp1&8 wouldn't play the pnm:// 
> stream dumps, which mplayer can play of course. So it seems real1 has room to 
> improve :]

it will never play the stream dumps, they are (afaik) not legal streams.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino