[MPlayer-dev-eng] -geometry code and -vo fbdev broken

[Attila Kinali]

On Sun, 23 Feb 2003 16:07:27 +0100
Michael Niedermayer <michaelni at gmx.at> wrote:


> does it work with "-vop scale" ? 

Juup works, there was a "broken, this should use the swscaler"
message, but i thought this was because of the general brokennes of 
fbdev :)

> this bug is likely caused by the latest 
> yuv2rgb changes, all vo's which directly use the yuv2rgb code are broken now 
> :(, IMHO vo's shouldnt do such conversion themselfs, instead the video filter 
> layer should do it, but if ppl disagree then ill fix all the affected vo's so 
> that they use the swscaler internally for the conversion (the yuv2rgb code 
> uses the swscaler context now ...)

Hmm... I dont fully understand what you mean (i'm not as much in
touch with the mplayer code as i'd like to :( )
But i agree, vo's shouldnt do any conversion but request it from
the vop layer. If you can fix it, please do, we already have too many
workarounds for mplayer internal stuff.

		Attila Kinali

-- 
Emacs ist für mich kein Editor. Für mich ist das genau das gleiche, als wenn
ich nach einem Fahrrad (für die Sonntagbrötchen) frage und einen pangalaktischen
Raumkreuzer mit 10 km Gesamtlänge bekomme. Ich weiß nicht, was ich damit soll.
		-- Frank Klemm, de.comp.os.unix.discussion