[MPlayer-dev-eng] Re: [patch] improve dxr3 tv norm switching

[David Holm]

On Thursday 02 January 2003 21:18, Thomas Jarosch wrote:
> > I have removed the unnecessary ones in cvs.
>
> Looks good.
>
> We could furthermore remove
>
> #ifdef MVCOMMAND_SYNC
> #ifdef EM8300_IOCTL_FLUSH
>
> as they are already in em8300 0.12.0 (just checked)

Yup, they can be removed as well.

> > Hmm, ok... most if not all of those lines were written by Pontscho
> > and not me.
>
> So, what is the right course of action? I'd say capitalized letters and
> ".". And maybe replace perror() with printf()...

Yep.. perror is from the overlay code I copied from the dxr3 project. That is
why it isn't structured like the rest of the vo_dxr3 code.

//David