[MPlayer-dev-eng] Re: [patch] improve dxr3 tv norm switching

Thomas Jarosch tomj at simonv.com
Thu Jan 2 23:48:48 CET 2003


> > We could furthermore remove
> >
> > #ifdef MVCOMMAND_SYNC
> > #ifdef EM8300_IOCTL_FLUSH
> >
> > as they are already in em8300 0.12.0 (just checked)
>
> Yup, they can be removed as well.

Already seen via web-CVS :-)

> > > Hmm, ok... most if not all of those lines were written by Pontscho
> > > and not me.
> >
> > So, what is the right course of action? I'd say capitalized letters and
> > ".". And maybe replace perror() with printf()...
>
> Yep.. perror is from the overlay code I copied from the dxr3 project. That
> is why it isn't structured like the rest of the vo_dxr3 code.

Ok, I'll checkout the current CVS now and will create a patch.

Thomas




More information about the MPlayer-dev-eng mailing list