[MPlayer-dev-eng] Re: Some cleanup about mencoder.

[Andriy N. Gritsenko]

    Hi, Arpi!

Sometime (on Saturday, January 18 at  0:17) I've received something...
>>     I've looked into code and I was wonder why there are variables muxer
>> and muxer_f into mencoder.c and tsese are _always_ implicitly used by any
>> of ve_*, and more of that - mencoder_write_chunk defined explicitly (!)
>> everywhere in *.c files! Since there are only muxer and muxer file (it's
>> impossible in current code have to another ones and it's too weird to
>> have another, IMHO) so I could simplify all muxer_* code well. :)  Please
>> commit it. :)

>WTF is this?

>i won't commit, it's nonsense.

    Why noncense?? I could say it's noncense to define variable but use
it in other source file only. And it's bad to define some function in
many source files as external but never in headers, good (non-crashable)
way is to define it in header. I did it that way so why do you call it
noncense? Or you prefer to have as many bugs and holes as possible? :(
Sorry if I said anything offensive but I used to write my C code without
hidden holes.

    Be happy!
    Andriy.