[MPlayer-dev-eng] Re: Some cleanup about mencoder.

[Arpi]

Hi,

>     Why noncense?? I could say it's noncense to define variable but use
> it in other source file only. And it's bad to define some function in
example?

> many source files as external but never in headers, good (non-crashable)
> way is to define it in header.
agree

> I did it that way so why do you call it
> noncense? Or you prefer to have as many bugs and holes as possible? :(
> Sorry if I said anything offensive but I used to write my C code without
> hidden holes.

you rpatch removed parameters of some muxer func and made static vars
global. imho it's bad.

yes, NOW it's not possible to have more than one muxer, but the muxer
API was designe dto make it possible with a new generation mencoder.c later


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu