[MPlayer-dev-eng] [PATCH] Fix Playlist fallback, when using gui ...

[Fabian Franz]

Am Mittwoch, 29. Januar 2003 12:43 schrieb Arpi:
> Hi,
>
> > while playing with mozilla-mplayerplug-in and its gui-support I noticed
> > that the GUI was not able to handle the new playlist fallback and gets
> > into an endless loop.
>
> could you detail the problem?
> why does it gets to loop, where etc.

ok, play any playlist:

do:

gmplayer -playlist a.pls - and its works fine

do:

gmplayer, load a playlist and it also works fine ...

do:

gmplayer a.pls and it will continue to play a.pls ever and ever again ....

Why? 

Because in the GUI-Idle loop mplayer uses mconfig to get the commandline and 
creates a new playtree ...

So Albeu, or whoever wrote that part forgot, that there could be dynamically 
expanding playlists ... (esp. fallback playlist :-( )

As long as there is only one file, or it is in the mconfig, it does work fine, 
but as soon as there are more than one, mlayer sees, ah there is another 
file, recreates the playtree and plays the same file ever and ever again, 
this seems to be the same bug, that Gabucino found today with -menu ...

The playtree-code is nice, but it has one big drawback, it does too many 
things that are not encapsulated in functions and are in main mplayer.c ... 
(should be changed after 0.90)

The GUI-Idle code should only be entered, if there is nothing to play anymore, 
such playtree=empty and such filename==NULL...

I tried it, and it did work ...

>
> > I hope attached patch is the right fix ... Did some tests, but cannot say
> > I'm 100% sure, because I normally don't use the gui :-/ ...
>
> i think it's a bad fix, it will break 'gmplayer filename', but i'm not sure
> too, i don't know the gui code.

It will not break it ... but ok, it IS bad fix ...

It seems to have some other problems :-(( (gmplayer test/* seems to get into 
endless loops too)

I'll test more ...

> but i don't even understand the conition of the bug.

see above ...
>
>
> A'rpi / Astral & ESP-team