[MPlayer-dev-eng] [PATCH] vf_eq2 extensions

[D Richard Felker III]

On Fri, Jan 31, 2003 at 05:47:33PM +0100, Daniel Moreno wrote:
> Hampa Hug wrote:
> 
> >This would probably be a good idea but I'm not sure the performance
> >gain is worth the extra complexity. From my point of view it is
> >not.
> 
> I agree.

To me, complexity is having to figure out what combinations of options
will be slow, and which will be fast. It's much simpler if I know
things will always be fast if I use -vop eq and always be slow if I
use -vop eq2.

> >To settle this issue it would be interesting to know who uses
> >these filters at all (and for what purposes). From the fact that
> >there hasn't been a gamma correction filter in MPlayer for quite
> >some time I conclude that most people do gamma correction somewhere
> >else.
> 
> Personaly, I've never used "eq". It can be as fast as it wants, but... 
> I've not yet found a video requiring brightness/contrast adjustment. 
> Usually they're properly mastered.

Think of recordings from TV. Lots of times people make them with the
brightness/contrast settings on their tv card all wrong. Also if you
have a movie with really bad ringing artifacts, lowering the contrast
can make it less painful to watch.

Rich