[MPlayer-dev-eng] [PATCH] vf_eq2 extensions

[Arpi]

Hi,

> > > I am reluctant to put this stuff in vf_eq.c because the main
> > > function that I need (the main reason for vf_eq2 to exist) is
> > > gamma correction and that's the one thing that can't be done
> > > efficiently in vf_eq.c.
> > perhaps the eq & eq2 filters should be merged and then depending upon the user 
> > settings (gamma or not) a LUT based eq is used or the add/mul mmx/c stuff ...
> 
> This would probably be a good idea but I'm not sure the performance
> gain is worth the extra complexity. From my point of view it is
> not.

extra complexity? it shouldn't be more complex that eq plus eq2 now.
i support the idea of single eq filter with all option and doing only the
needed conversions (mmx or lut-based, depending on linearity of parameters)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino