[MPlayer-dev-eng] Re: [PATCH] theora support

[David Kuehling]

Arpi wrote:

> sure. use MP_IMGTYPE_EXPORT

Overlooked that.  This should be very compatible with Theora's YUV
buffer.

> your codec implementation is messy at several points, misuse flags and
> so on. it's on my TODO to reimplement/fix but i'm busy with G2
> nowdays.

Sorry.  Never forget what a beast mplayer is.  Amost impossible to get
it right the first time ;-)  If you comment on the issues which annoy
you, I'll check it out, might save your time for more important tasks.

> the best would be if theora codec could decode into memory allocated
> by mplayer core, hopefully in Xv or video card's memory area.

Impossible with the current libtheora.  Someone could start a thread on
theora-dev about implementing a more efficient decoder interface with
slice support etc.

> could you create a sample file playable wiht your patch, and upload to
> mplayerhq.hu ftp for testing?

I'll today try to upload a low-quality TV recording which I converted
from MPEG4 to Theora.

BTW according to a recent mail from Mike Melanson on theora-dev, ffmpeg
is getting VP3 support.  The current implementation is still incomplete
and might never be 100% compatible.  But it should be much faster than
libtheora.

David Kühling
-- 
GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg
Fingerprint: B17A DC95 D293 657B 4205  D016 7DEF 5323 C174 7D40