[MPlayer-dev-eng] vo_xv broken

[Michael Niedermayer]

Hi

On Thursday 15 May 2003 19:39, Alex Beregszaszi wrote:
> Hi,
>
> today I came across a huge bug.
> The problem: -vo xv crashes togethet with vd_lcl (-vc mpzlib) playing a
> test movie avizlib_sample.avi (it crashes after draw_image). It plays
> fine with -vo x11.
>
> So I looked at that draw_image, and there's inside an exception against
> BGR24, AHHA, so it calls rgb24toyv12 natively! Why does it supports
> that? Anyway, that should be fine - disabling it, everything worked
> (-vop scale got called).
>
> Then I ran -vo xv with an mpeg1 together with -vop format=bgr24,
> to see if -vo xv works with bgr24, and it does! Why? Becouse the new
> swscale calls sws_rgb2rgb_init() once, so the rgb24toyv12 will be set.
> So one should call that function in the vo_xv init.
>
> Michael: what should be the proper wise? I vote for removing all
> the conversions from the vo's.
agree

[...]

-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en