[MPlayer-dev-eng] Altivec+GCC fix

Alex Beregszaszi alex at fsn.hu
Wed May 21 20:36:58 CEST 2003


Hi,

Some comments:

> * configure
>   Check for altivec.h and set HAVE_ALTIVEC_H
>   This is required for the new libmpeg2 files and for 
>   the updated ffmpeg code
>   make sure ARCH_POWERPC gets set
>   (I choosed this instead of mpeg2_internal)
>
> * libmpcodecs/vd_libmpeg2.c
>   Make sure that altivec gets enabled in libmpeg2
these two parts above are ok

> * libmpeg2/Makefile
>   Make sure the correct flags are passed to CC
>   Altivec files should only be compiled when altivec is enabled.
> 
> * libmpeg2/idct.c
>   Only use Altivec if enabled with configure.
> 
> * libmpeg2/motion_comp.c
>   Only use Altivec if enabled with configure.
ok, but do the libmpeg2 on sf.net made those changes?
I mean, there was an #ifdef __ALTIVEC__ in all the altivec related
files, and they have been compiled everytime, but without altivec
support, they're only empty objects. The two ways do the same, probably
the old one is messier, and I prefer your version too, but it should be
in sync with the main libmpeg2 branch!

> * libmpeg2/idct_altivec.c
>   Updated to version 1.19 from sourceforge
>   This version includes the gcc bugfix
>   The new file also ditches the old assembly version
>   and it must be built with correct altivec-flags
> 
> * libmpeg2/motion_comp_altivec.c
>   Updated to version 1.12 from sourceforge
>   The old version crashed my gcc-3.2.2 (after allocating 1 Gig memory)
>   because of unfriendly altivec code, the new file is better.
>   The new file ditches the old assembly version
>   and it must be built with correct altivec-flags
Okay, I wanted to ask if they're synced with the main libmpeg2, and they
are, but you've included some fixes, have you sent your patches to the
developers? If not, do it!

-- 
Alex Beregszaszi <alex at fsn.hu>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)



More information about the MPlayer-dev-eng mailing list