[MPlayer-dev-eng] [PATCH] Fw: rtsp fixes (buffer size,redirections)

Sascha Sommer saschasommer at freenet.de
Wed May 28 23:09:39 CEST 2003


> If yepyep is not on the list, please forward him my answer.
> 

Done

> > > okay that way. this patch also fixes the problem with the buffers
> > > being too small in sdpplin.c and the resulting crashes and
> > > non-working streams. i think 255 should be a decent size for them.
> It's not required here (not in MPlayer nor in xine).
> Can you explain when it's required? xbuffers (like the original 
> xine_buffers) should expand the allocated memory when you try to copy 
> into them something that's bigger than current buffer (if used 
> correctly). Maybe there's a bug in my xbuffer implementation or in the 
> original xine_buffer usage.

Afair this caused memory corruption for him
rtsp://video.id.ucsb.edu/excellence.rm

rtsp://rd01.t-bn.de/live/viva/viva1tv_live_adsl.rm (lots of read errors)
rtsp://video.ohiolink.edu:554/OLN/2000/120-23-1b.rm (buffer overflow)


(They all work with the patch)

Sascha



More information about the MPlayer-dev-eng mailing list