[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix
Diego Biurrun
diego at biurrun.de
Fri Oct 17 15:25:21 CEST 2003
Hampa Hug writes:
> Here's the patch that adds default parameters to vf_eq2.
Works nicely, thanks.
> I changed the order of parameters from gamma:contrast:brightness to
> gamma:brightness:contrast. I think that's the best solution.
Umm, I beg to differ ;-)
The best solution would be brightness:contrast:gamma IMHO in order to
be consistent with -vf eq. If you only want to specify gamma you will
have to use -vf eq2=::XX, but that is only a small inconvenience for
you resulting in a big gain in usability and consistence for the rest,
so please consider making that change.
Diego
More information about the MPlayer-dev-eng
mailing list