[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[Arpi]

Hi,

>  > I changed the order of parameters from gamma:contrast:brightness to
>  > gamma:brightness:contrast. I think that's the best solution.
> 
> Umm, I beg to differ ;-)
> 
> The best solution would be brightness:contrast:gamma IMHO in order to
> be consistent with -vf eq.  If you only want to specify gamma you will
> have to use -vf eq2=::XX, but that is only a small inconvenience for
> you resulting in a big gain in usability and consistence for the rest,
> so please consider making that change.

I disagree.
for brightness/contrast changes you should not use eq2, but eq.
eq2 uses table lookup, which is a lot slower than mmx for simple
transformations like the ones needed for bri/contrast change.
but LUT is needed for gamma, which is the primary goal of eq2.
so you use eq2 only if you want gamma transform, and you may
optinally also set brightness/contrast too with it (to avoid
using 2 filters, both eq + eq2).
anyway since a while the vf_scale filter can do bri/contrast
changes too so 'eq' is getting outdated/redundant.


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu