[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix
Hampa Hug
hampa at hampa.ch
Tue Oct 21 03:10:32 CEST 2003
Diego Biurrun wrote:
> Hampa Hug writes:
> > I changed the order of parameters from gamma:contrast:brightness to
> > gamma:brightness:contrast. I think that's the best solution.
>
> Umm, I beg to differ ;-)
>
> The best solution would be brightness:contrast:gamma IMHO in order to
> be consistent with -vf eq. If you only want to specify gamma you will
> have to use -vf eq2=::XX, but that is only a small inconvenience for
> you resulting in a big gain in usability and consistence for the rest,
> so please consider making that change.
OK, here it is. I'm still not convinced, but your wish is my
command ;-)
Besides, there were some changes to vf_eq2 lately and the old
patch doesn't apply cleanly anymore, so I had to redo it
anyway.
Hampa
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: eq2-2.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031021/e0734db0/attachment.txt>
More information about the MPlayer-dev-eng
mailing list