[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix
Diego Biurrun
diego at biurrun.de
Tue Oct 28 12:47:28 CET 2003
Hampa Hug writes:
> Diego Biurrun wrote:
> > Hampa Hug writes:
> > > I changed the order of parameters from gamma:contrast:brightness to
> > > gamma:brightness:contrast. I think that's the best solution.
> >
> > Umm, I beg to differ ;-)
> >
> > The best solution would be brightness:contrast:gamma IMHO in order to
> > be consistent with -vf eq. If you only want to specify gamma you will
> > have to use -vf eq2=::XX, but that is only a small inconvenience for
> > you resulting in a big gain in usability and consistence for the rest,
> > so please consider making that change.
>
> OK, here it is. I'm still not convinced, but your wish is my
> command ;-)
>
> Besides, there were some changes to vf_eq2 lately and the old
> patch doesn't apply cleanly anymore, so I had to redo it
> anyway.
If nobody objects I am going to commit this in the next days.
Diego
More information about the MPlayer-dev-eng
mailing list