[MPlayer-dev-eng] [PATCH] stay-on-top

[Diego Biurrun]

First off, very nice work!  Dunno if this is the best or cleanest way
to implement it, but we have definitely been missing this
functionality.

Your patch is still missing two things at least, though.  You should
add a -noontop option, so that it is possible to override the config
file on the command line and you should document the -ontop option in
the man page.

Tomas Groth writes:
 > Made the changes, and now xv, x11, gl and gl2 is working. In
 > theory it should also work with xmvc, xover and xvidix.
 > xmga should work with the commandline option, but it seems
 > that there are no "control" function for that driver...?

You need to make some changes in mga_common.c.  The following does the
trick for me:


--- mga_common.c	1 Jun 2003 21:59:28 -0000	1.57
+++ mga_common.c	26 Oct 2003 23:16:15 -0000
@@ -331,6 +331,9 @@
       vo_x11_fullscreen();
       vo_panscan_amount=0;
     /* indended, fallthrough to update panscan on fullscreen/windowed switch */
+  case VOCTRL_ONTOP:
+      vo_x11_ontop();
+      return VO_TRUE;
 #endif
   case VOCTRL_SET_PANSCAN:
       if ( vo_fs && ( vo_panscan != vo_panscan_amount ) ) // || ( !vo_fs && vo_panscan_amount ) )


 > sdl does not work at all. Don't know how to add support for
 > stay-on-top in that driver!

I had a look at this myself, but I have no idea how to do it.  Atmos?

A general (and probably very naive) question to the rest of you: Do we
need to implement this for every vo or is there a more general way to
do it?

Diego