[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[Torinthiel]

On Tue, Oct 28, 2003 at 04:09:55PM +0100, Arpi wrote:
> Hi,
> 
> > So, to sum up the only change I ment to suggest was (no patch, maybe
> > later):
> > eq[=bright:cont]
> > eq2[=gamma:bright:cont:saturation:rg:gg:bg]
> 
> I see 2 objections:
> - breaks existing scripts (Rich has right)
> - then also swap 1;2 and 3;4 key mappings, as 1;2 are contrast and 3;4 are
> brightness. to be consistent, it should be swapped too.
> (i always try to set brightness with 1;2 and wonder why doenst work...)
The keys should be consistent. But with what? eq or eq2? As now it is
impossible to make with both ;)
> 
> Imho Rich is right, we should not chaneg behaviour without very good reasons.
Problem is if consistency is a good enough reason.

> A'rpi / Astral & ESP-team
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3075312
   torinthiel(at)wp(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031028/c5bf9a2e/attachment.pgp>