[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[Diego Biurrun]

Arpi writes:
 > > Looks like I started the whole thread, so maybe it's time I say
 > > something more ;)
 > > I've noticed (at that time) that eq uses bright:cont and 
 > > eq2 uses gamma:cont:bright:...
 > > It was inconsistent of course, but I wasn't against idea of putting
 > > gamma first. Eq2, after all, is a separate filter, so it can have
 > > different parameters. And it applies to me that gamma is the most often
 > > used parameter, in fact if you don't use gamma then you could not use
 > > this filter. What I had ment was ONLY that brightness and contrast
 > > should be in the same order in both filters. Right now there are in
 > > different order, so if someone wants to remember the params he has to
 > > remember that once brightness is firs, once contrast is and where is
 > > what.
 > > So, to sum up the only change I ment to suggest was (no patch, maybe
 > > later):
 > > eq[=bright:cont]
 > > eq2[=gamma:bright:cont:saturation:rg:gg:bg]
 > 
 > I see 2 objections:
 > - breaks existing scripts (Rich has right)

I agree that we should not change options without good reason.  But
consistency is very important for the usability of a program and a
good reason for these kinds of changes IMHO.

Things like this should not change between stable releases, e.g. 0.90
--> 0.91, but when going from 0.90 --> 1.0 it is acceptable to have
these kinds of small changes.

 > - then also swap 1;2 and 3;4 key mappings, as 1;2 are contrast and 3;4 are
 > brightness. to be consistent, it should be swapped too.
 > (i always try to set brightness with 1;2 and wonder why doenst work...)

I fully agree, they should be swapped as well.

Diego