[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[Diego Biurrun]

Arpi writes:
 > >  > > The best solution would be brightness:contrast:gamma IMHO in order to
 > >  > > be consistent with -vf eq.  If you only want to specify gamma you will
 > >  > > have to use -vf eq2=::XX, but that is only a small inconvenience for
 > >  > > you resulting in a big gain in usability and consistence for the rest,
 > >  > > so please consider making that change.
 > >  > 
 > >  > OK, here it is. I'm still not convinced, but your wish is my
 > >  > command ;-)
 > >  > 
 > >  > Besides, there were some changes to vf_eq2 lately and the old
 > >  > patch doesn't apply cleanly anymore, so I had to redo it
 > >  > anyway.
 > > 
 > > If nobody objects I am going to commit this in the next days.
 > 
 > I do object, and i've already explained why in a different branch of this
 > thread.
 > 
 > vf_eq2 is mostly used for gamma settings, and so its normal and natural
 > that gamma is the first (and recommended) parameter.
 > others (contrast brightness etc) are rarely used with this filter,
 > a sthere are much more faster and efficient filters for that (vf_eq and
 > scale, but most users don't need them as vo driver can do it as well)

Hmm, if I understood the discussion correctly, then vf_eq2 is as fast
as vf_eq if no gamma correction is used.  The man page suggests the
same:

  eq2[=gamma:contrast:brightness:saturation:rg:gg:bg]
    Alternative software equalizer that uses lookup tables (very
    slow), allowing gamma correction in ad dition to simple brightness
    and contrast adjustment.  Note that it uses the same MMX optimized
    code as -vf eq if all gamma values are 1.0.

Is this wrong?  You also said that vf_eq was obsolete and should be
superseded by vf_eq2, so I assumed there was no speed penalty.

In the beginning of this thread is a patch that leaves gamma as first
parameter.  Is it OK to commit that one?  The parameter order is easy
to change later (if we should want to).

Diego