[MPlayer-dev-eng] [PATCH] totally disable encoding stuff when selecting --disable-mencoder

[Aurelien Jacobs]

On Sun, 5 Dec 2004 15:38:54 -0500
D Richard Felker III <dalias at aerifal.cx> wrote:

> On Sun, Dec 05, 2004 at 10:32:58AM +0100, Gianluigi Tiesi wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > I'm adding a small patch to disable encoder stuff at all when
> > configure is called
> > with --disable-mencoder (there are some drawbacks I don't known ???)
> > 
> > My patch is to take only as reference since it modifies both ffmpeg
> > and mplayer files,
> > so I think there should be a better way. I would only make known
> > this minor problem.
> 
> the changes to ffmpeg files are not required or useful. the
> compiler/linker will omit the code that's not needed.

I'm not sure about this. IMHO global symbols such as snow_encoder and
h261_decoder should be ifdefed.
But it's probably not useful to ifdef encode_init which is static
(except that it may triger a warning, but you probably don't care).

Anyway the changes to ffmpeg should probably go to the ffmpeg
mailing list.

Aurel