[MPlayer-dev-eng] [PATCH] totally disable encoding stuff when selecting --disable-mencoder

[Arpi]

Hi,

> On Sun, 5 Dec 2004 15:38:54 -0500
> D Richard Felker III <dalias at aerifal.cx> wrote:
> 
> > On Sun, Dec 05, 2004 at 10:32:58AM +0100, Gianluigi Tiesi wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > > 
> > > I'm adding a small patch to disable encoder stuff at all when
> > > configure is called
> > > with --disable-mencoder (there are some drawbacks I don't known ???)
> > > 
> > > My patch is to take only as reference since it modifies both ffmpeg
> > > and mplayer files,
> > > so I think there should be a better way. I would only make known
> > > this minor problem.
> > 
> > the changes to ffmpeg files are not required or useful. the
> > compiler/linker will omit the code that's not needed.
> 
> I'm not sure about this. IMHO global symbols such as snow_encoder and
> h261_decoder should be ifdefed.

yes.

recently i wrote a small mpeg4 avi player app for some company, using
libavcodec for decoding. although i disabled CONFIG_ENCODERS, and
instead of calling avcodec_register_all(), only called 
register_avcodec(&mpeg4_decoder), gcc (3.3.4) still linked most of
libavcodec to the resulting binary, and produced some errors related
to the snow codec and h263. probably it was some linker error, as when
i #if 0'd some if these then it compiled fine, but still a 2mb binary
after strip.

anyway, mplayer (and probably any other players with dynamic plugin
support) is compiled with -rdynamic, causing any (unused too!) non-static
functions are still linked to final binary.

so maybe adding #ifdef CONFIG_ENCODERS to more places in ffmpeg
could be a good idea...

> Anyway the changes to ffmpeg should probably go to the ffmpeg
> mailing list.

agree...


A'rpi / MPlayer, Astral & ESP-team

--
Girls are like internet domain names, the ones I like are already taken.