[MPlayer-dev-eng] [PATCH] [RFC] New audio filter: LADSPA plugin loader

[Reimar Döffinger]

Hi,

In the af_ladspa.c file you commented some parts of a struct with normal
comments. Better use a comment type that doxygen understands.

> That's about it. Just aply the patch, copy af_ladspa.c and ladspa.h to 

I don't really like to copy headers from other projects (or did you
modify it? If so you should mention it). Also I personally would prefer
a configure check for it, as this is a feature I almost certainly will
never use - or at most for playing around with it.

> If nobody objects, I'll commit it after the weekend. After that, I'll work 
> on the manpage.

I'd prefer it if the manpage was updated at the same time. And if you
want a real review you would have to give at least one week (although I
have to admit this is not so important with new and independant code as
this - though you should make sure it compiles on all platforms if you
want to leave it enabled by default as it is in this patch).

Greetings,
Reimar Döffinger