[MPlayer-dev-eng] [PATCH] [RFC] New audio filter: LADSPA plugin loader

[Ivo]

Hi,

On Saturday 11 December 2004 12:10, Reimar Döffinger wrote:
> In the af_ladspa.c file you commented some parts of a struct with normal
> comments. Better use a comment type that doxygen understands.

Ok, I'll change that.

> I don't really like to copy headers from other projects (or did you
> modify it? If so you should mention it). Also I personally would prefer
> a configure check for it, as this is a feature I almost certainly will
> never use - or at most for playing around with it.

I wasn't sure about this, so I added it anyway. But I checked now, and all 
major distro's (Debian, FC, SuSe, Mandrake) ship with the LADSPA SDK, so I 
will change this to what you suggest.

> I'd prefer it if the manpage was updated at the same time. And if you
> want a real review you would have to give at least one week (although I
> have to admit this is not so important with new and independant code as
> this - though you should make sure it compiles on all platforms if you
> want to leave it enabled by default as it is in this patch).

Agreed. I will wait a little longer before committing this. So, I urge 
everyone with a non-x86 and/or a non-Linux OS to compile this and see if it 
breaks :-)

As for the manpage, I'll try to write something down and post it on -docs so 
Diego & co. can review it. Most of the time they are a lot better than me 
at formulating compact and clear descriptions.

--Ivo