[MPlayer-dev-eng] [PATCH] Paths for x86_64

[Bernd Ernesti]

On Sun, Dec 26, 2004 at 01:51:31PM +0100, Martin Braun wrote:
> Diego Biurrun wrote:
> >On Sun, Dec 26, 2004 at 09:01:49AM +0100, Bernd Ernesti wrote:
> >
> >>This will break systems which don't use lib64 for x86_64, at least
> >>NetBSD.
> >>IMHO you need to do at least some tests to see if that directory
> >>exists at all and then some compiler test to see if you can use
> >>it.
> I did not know that.
> >
> >
> >I thought this looked fishy all along.  Patch rejected.
> >
> I can not see how this is worse than hardcoding $(prefix)/lib
> everywhere.

Come one, you need to do some basic checks if it works at all.
Right now you are planing to use directories, which don't exists
on all systems and therefor break them.

> Would a patch providing a `check_lib64' and a
> `use_lib64' shell function in configure get a better chance ?

It's not a bad idea to use $libdir, so why not do some checks and
then use it. I don't think you need to use some shell function,
wherever you are planing to use them or what you mean with shell
functions.

Bernd