[MPlayer-dev-eng] [PATCH] Paths for x86_64

[Martin Braun]

Bernd Ernesti wrote:
> On Sun, Dec 26, 2004 at 01:51:31PM +0100, Martin Braun wrote:
> 
>>Diego Biurrun wrote:
>>
>>>On Sun, Dec 26, 2004 at 09:01:49AM +0100, Bernd Ernesti wrote:
>>>
>>>
>>>>This will break systems which don't use lib64 for x86_64, at least
>>>>NetBSD.
>>>>IMHO you need to do at least some tests to see if that directory
>>>>exists at all and then some compiler test to see if you can use
>>>>it.
>>
>>I did not know that.
>>
>>>
>>>I thought this looked fishy all along.  Patch rejected.
>>>
>>
>>I can not see how this is worse than hardcoding $(prefix)/lib
>>everywhere.
> 
> 
> Come one, you need to do some basic checks if it works at all.
> Right now you are planing to use directories, which don't exists
> on all systems and therefor break them.
> 
> 
>>Would a patch providing a `check_lib64' and a
>>`use_lib64' shell function in configure get a better chance ?
> 
> 
> It's not a bad idea to use $libdir, so why not do some checks and
> then use it. I don't think you need to use some shell function,
> wherever you are planing to use them or what you mean with shell
> functions.
> 

Ok,
here is a new patch with the following changes:
- directories and compiler are checked
- no more messing with host_arch
- `-fPIC -DPIC' no longer added
- no longer select vidix by default for x86_64

The patch is split into two files. mplayer-libdir.patch contains changes
for MPlayer. mplayer-ffmpeg contains changes which are neccesary for
ffmpeg. These have been posted to ffmpeg-devel.

Greetings,

Martin
> Bernd
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-libdir.patch
Type: text/x-patch
Size: 3594 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041227/2e8e89c1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-ffmpeg.patch
Type: text/x-patch
Size: 2584 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041227/2e8e89c1/attachment-0001.bin>