[MPlayer-dev-eng] [PATCH] Paths for x86_64

[D Richard Felker III]

On Mon, Dec 27, 2004 at 12:07:10AM +0100, Martin Braun wrote:
> >>Would a patch providing a `check_lib64' and a
> >>`use_lib64' shell function in configure get a better chance ?
> >
> >
> >It's not a bad idea to use $libdir, so why not do some checks and
> >then use it. I don't think you need to use some shell function,
> >wherever you are planing to use them or what you mean with shell
> >functions.
> >
> 
> Ok,
> here is a new patch with the following changes:
> - directories and compiler are checked
> - no more messing with host_arch
> - `-fPIC -DPIC' no longer added
> - no longer select vidix by default for x86_64
> 
> The patch is split into two files. mplayer-libdir.patch contains changes
> for MPlayer. mplayer-ffmpeg contains changes which are neccesary for
> ffmpeg. These have been posted to ffmpeg-devel.

this patch is blatently incorrect. lib64 should NOT BE USED BY
DEFAULT!!! it is a broken, nonstandard practice by broken distros!!!
btw the shell code in the -dumpmachine parsing also has 5l nonsense in
it.

let me clarify: ANY patch containing lib64 crap will be rejected
unless it satisfies the following conditions:

- unobtrusive in the configure script, i.e. no bloated extra
  conditions or silly code that doesn't make sense.

- unobtrusive with respect to not messing up compile on
  standars-compliant x86-64 systems. this means lib64 can never be
  selected unless the script detects you're using a broken system with
  libraries in the wrong places. how you detect that is up to you, but
  some ideas are either specific distro-detection, or checking for the
  presence of $prefix/lib64 in the filesystem.

rich