[MPlayer-dev-eng] [PATCH] Paths for x86_64

[Reimar Döffinger]

Hi,
> >>>>This will break systems which don't use lib64 for x86_64, at least
> >>>>NetBSD.
> >>>>IMHO you need to do at least some tests to see if that directory
> >>>>exists at all and then some compiler test to see if you can use
> >>>>it.
> >>
> >>I did not know that.
> >>>
> >>>I thought this looked fishy all along.  Patch rejected.
> >>
> >>I can not see how this is worse than hardcoding $(prefix)/lib
> >>everywhere.
> >
> >Come one, you need to do some basic checks if it works at all.
> >Right now you are planing to use directories, which don't exists
> >on all systems and therefor break them.
> >
> >>Would a patch providing a `check_lib64' and a
> >>`use_lib64' shell function in configure get a better chance ?
> >
> >It's not a bad idea to use $libdir, so why not do some checks and
> >then use it. I don't think you need to use some shell function,
> >wherever you are planing to use them or what you mean with shell
> >functions.
> 
> Ok,
> here is a new patch with the following changes:
> - directories and compiler are checked
> - no more messing with host_arch
> - `-fPIC -DPIC' no longer added
> - no longer select vidix by default for x86_64

Could you split it in two parts? One that fixes the makefiles to use
libdir (which can be specified to the configure command) and one
containing the auto-selection lib vs. lib64.
Because the first one definitly fixes a bug and I am willing to apply it, whereas I can't test the second part and have not the necessary knowledge to check it.
Not to mention that it is much more code and far more likely to break
something.

Greetings,
Reimar Döffinger