[MPlayer-dev-eng] [PATCH] OpenDML AVI2.0 read support

[D Richard Felker III]

On Fri, Feb 06, 2004 at 04:26:46PM -0500, The Wanderer wrote:
> Attila Kinali wrote:
> 
> >On Fri, 6 Feb 2004 16:09:51 +0100 (CET)
> >Tilmann Bitterberg <transcode at tibit.org> wrote:
> >
> >>Here is an updated version of the patch (fixes a few bugs)
> >>Tested with a 5.4 GB AVI file:
> >
> >I just had a very quick look at it.
> >Please change the printfs to mp_msg calls.
> 
> Apropos of this: as of this morning's CVS, there are (depending on which
> way you count it - I haven't been able to put together a reliable
> regular expression which doesn't return false positives) between several
> hundred and a few thousand printf() calls under the MPlayer source tree,
> not counting any from libavcodec. Given stated policy, I'd like to ask
> if there is any reason - other than "no one noticed enough to point it
> out" - why these made it in without being changed to mp_msg() or similar
> calls? For that matter, would there be any problem with changing them,
> if someone wanted to do the work of tracking them all down?

They should all be changed. The only reason they haven't is laziness.
BTW, when changing them one needs to decide which message level to put
them at, not just blindly search-and-replace. If you do blind s&r now,
it would work ok, but then later on when someone wants to fix the
message levels, it'll be difficult to figure out which messages
already have intentionally-assigned levels and which don't.

Rich