[MPlayer-dev-eng] [BUG] Mplayer 1.0 pre5 ppc/altivec issues

[Michael Niedermayer]

Hi

On Thursday 15 July 2004 20:21, Magnus Damm wrote:
> On Thu, 2004-07-15 at 15:12, Michael Niedermayer wrote:
> > On Thursday 15 July 2004 09:58, Magnus Damm wrote:
> > > I'm unable to compile pre5 too. My PPC box runs Linux.
> > > Adding a "#include <altivec.h> in "swscale_internal.h" helped a bit,
> > > but more fixes are needed for "yuv2rgb_altivec.c".
> > > I'm using a gcc from FSF.
> >
> > does reversal of the attached patches fix the issue? they should have
> > never been applied anyway, but alex and diego repeatedly asked me to
> > apply them so i did
>
> Well, yes, the attached patches solves the problem. Thank you. But it
> all depends on what you want to do. I mean, yes, it successfully
> disables the altivec code. 
no, it only disables (the broken) part of it

> But maybe it is a good thing to have altivec 
> acceleration? 
yes, but that compilation issue is just one problem of that patch (see the 
commit message), if someone fixes it iam surely very happy, but in their 
current state even if the compilation stuff is fixed, the patches should be 
reversed IMHO

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en