[MPlayer-dev-eng] [BUG] Mplayer 1.0 pre5 ppc/altivec issues

[Luca Barbato]

Magnus Damm wrote:
> On Thu, 2004-07-15 at 15:12, Michael Niedermayer wrote:
> 
>>On Thursday 15 July 2004 09:58, Magnus Damm wrote:
>>
>>>I'm unable to compile pre5 too. My PPC box runs Linux.
>>>Adding a "#include <altivec.h> in "swscale_internal.h" helped a bit,
>>>but more fixes are needed for "yuv2rgb_altivec.c".
>>>I'm using a gcc from FSF.
>>
>>does reversal of the attached patches fix the issue? they should have never 
>>been applied anyway, but alex and diego repeatedly asked me to apply them so 
>>i did
> 
> 
> Well, yes, the attached patches solves the problem. Thank you. But it
> all depends on what you want to do. I mean, yes, it successfully
> disables the altivec code. But maybe it is a good thing to have altivec
> acceleration? I rather see FSF-gcc support in the code. We can at least
> find a solution where it is enabled for Darwin and disabled otherwise.
> 
> I added the file "libavcodec/ppc/gcc_fixes.h" to solve things like this.
> But it is probably not a good idea to include that one from code under
> "postproc/"...
> 
> lu, are you working on FSF-gcc support in "yuv2rgb_altivec.c"?
> 
> / magnus 
> 

I almost finished a "kludge patch" it should at least let you build 
everything, I could bet that that code will break something somewhere, 
please audit the patch.

Here worked using gcc-3.4.1 fsf

lu


-- 
Luca Barbato
Developer
Gentoo Linux				http://www.gentoo.org/~lu_zero


-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-1.0_pre5-yuv2rbg_kludge.patch
Type: text/x-patch
Size: 12585 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040715/c105d094/attachment.bin>