[MPlayer-dev-eng] [PATCH] Extended DVD-arguments

Moritz Bunkus moritz at bunkus.org
Sun Oct 17 17:57:09 CEST 2004


Hey,

> Haha, sorry :) saw that I had disabled expand-tab in vim,  here I
> attach it expanded

That doesn't make it better. Your indentation is still way off:

>      ifo_handle_t *vmg_file;
>      tt_srpt_t *tt_srpt;
>      ifo_handle_t *vts_file;
> -    dvd_title = filename[6] == '\0' ? 1 : strtol(filename + 6,NULL,0);
> +
> +        /**
> +         * dvd://title:chapter-last_chapter:angle@dvd-device
> +         * dvd://1:1-4:1@/dev/dvd
> +         */

etc. The original code uses four spaces, you use eight. See the
difference? :)

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds




More information about the MPlayer-dev-eng mailing list