[MPlayer-dev-eng] [PATCH] Extended DVD-arguments

Carl Fûrstenberg azatoth at gmail.com
Sun Oct 17 18:09:49 CEST 2004


On Sun, 17 Oct 2004 17:57:09 +0200, Moritz Bunkus <moritz at bunkus.org> wrote:
> Hey,
> 
> > Haha, sorry :) saw that I had disabled expand-tab in vim,  here I
> > attach it expanded
> 
> That doesn't make it better. Your indentation is still way off:
> 
> >      ifo_handle_t *vmg_file;
> >      tt_srpt_t *tt_srpt;
> >      ifo_handle_t *vts_file;
> > -    dvd_title = filename[6] == '\0' ? 1 : strtol(filename + 6,NULL,0);
> > +
> > +        /**
> > +         * dvd://title:chapter-last_chapter:angle@dvd-device
> > +         * dvd://1:1-4:1@/dev/dvd
> > +         */
> 
> etc. The original code uses four spaces, you use eight. See the
> difference? :)
> 
> 

haha, again sorry, I must be tired, hope you can understand the code
at minimum :)

third time even?
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mplayer_dvd_arg.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041017/0bae45b9/attachment.asc>


More information about the MPlayer-dev-eng mailing list