[MPlayer-dev-eng] [PATCH] Extended DVD-arguments

Carl Fûrstenberg azatoth at gmail.com
Mon Oct 18 09:54:46 CEST 2004


On Sun, 17 Oct 2004 18:09:49 +0200, Carl Fûrstenberg <azatoth at gmail.com> wrote:
> On Sun, 17 Oct 2004 17:57:09 +0200, Moritz Bunkus <moritz at bunkus.org> wrote:
> > Hey,
> >
> > > Haha, sorry :) saw that I had disabled expand-tab in vim,  here I
> > > attach it expanded
> >
> > That doesn't make it better. Your indentation is still way off:
> >
> > >      ifo_handle_t *vmg_file;
> > >      tt_srpt_t *tt_srpt;
> > >      ifo_handle_t *vts_file;
> > > -    dvd_title = filename[6] == '\0' ? 1 : strtol(filename + 6,NULL,0);
> > > +
> > > +        /**
> > > +         * dvd://title:chapter-last_chapter:angle@dvd-device
> > > +         * dvd://1:1-4:1@/dev/dvd
> > > +         */
> >
> > etc. The original code uses four spaces, you use eight. See the
> > difference? :)
> >
> >
> 
> haha, again sorry, I must be tired, hope you can understand the code
> at minimum :)
> 
> third time even?
> 
> 
> 

I just saw something, and have to ask, is it chapter or title or both
that have first-last?




More information about the MPlayer-dev-eng mailing list