[MPlayer-dev-eng] [PATCH] fix for -srate bug

Ed Wildgoose lists at wildgooses.com
Wed Oct 20 11:22:30 CEST 2004


>there is _no_excuse_ for including support for a different totally
>unoptimized resampler that just duplicates functionality of lavc...
>  
>

Hi Richard,

I detect more than a hint of frustration in the tone of your messages.   
It's not my intention to wind you up over this issue!  I want to solve 
my issues in a way that works for everyone, but please bear in mind that 
I am not very experienced in the inner workings of mplayer, and it's 
obviously easier for you with a knowledge of the various options.available.

At the end of the day I have no issue with how a resampler is 
implemented.  Obviously I can just hack my local copy of mplayer and 
shut-up, but I think that this would be a useful addition to the code so 
I would like to implement any changes in a way that are acceptable to 
the dev team. 

With this in mind, can you please have a look at the email by Michael 
Niedermayer.  I am a bit confused, but he seems to have tested lavc and 
reports good performance, but some significant loss of resolution (SNR 
is significantly lower).  Can you please interpret his finding and offer 
an opinion as to whether Lavc is still the best option?

Also, as a programming beginner with mplayer, can you help me out with 
architecture in terms of how one would hook in lavc to replace the 
current resampler code.  Would you envisage me simply rewriting the 
current resample module in libaf to use lavc?

Look, I really am NOT trying to push something on people that they don't 
want, this is strictly an optional type thing.  It's just that I am 
suprised that with some headphones that it wouldn't be easy to hear even 
the high quality resampler having an audible effect.  And in my case in 
a living room with a surround setup and 8 amplifiers pumping quite loud, 
it's quite obvious that something is not quite right.  Since this kind 
of setup is a few hundred quid (ie UKP) from Dixons these days then I 
don't think that it's unreasonable to shoot for this kind of quality.

I hope this is an acceptable position and that you can now see where I 
am coming from?

Thanks

Ed W




More information about the MPlayer-dev-eng mailing list