[MPlayer-dev-eng] Stuck mouse buttons

[Diego Biurrun]

The Wanderer writes:
> Diego Biurrun wrote:
> 
> > Marius Gedminas writes:
> > 
> >> Occasionally (but often enough to get annoying) when I click a
> >> mouse button on an mplayer window the button gets stuck
> 
> >> I've traced the problem to mplayer_put_key in fifo.c.
> 
> > I just tested this patch and it works as advertised.  We should
> > really fix this ancient bug.  Somebody please review and commit this.
> 
> I'm not sure what "reviewing" consists of in this type of context, aside
> from looking the code over and saying "it looks okay to me" (in which
> case I wouldn't be remotely qualified to pass on it), but at the very
> least the printfs it adds to fifo.c will need to be changed to mp_msg.

Yes, you're right.  In this case the printfs look like mere debugging
aids, though, so I would guess commenting them out (like the others in
that file) should suffice.

Diego