[MPlayer-dev-eng] [PATCH] some small updates

[Joey Parrish]

On Sun, Apr 03, 2005 at 03:23:39PM +0200, Diego Biurrun wrote:
> On Sat, Mar 19, 2005 at 04:45:51AM +0000, adland wrote:
> > I am enclosing a set of small possible updates in this PATCH
> > please review
> > libao2/ao_esd.c - replace printf with mp_msg 
> > 
> > --- main/libao2/ao_esd.c	2005-01-13 09:32:31.000000000 -0500
> > +++ updated/libao2/ao_esd.c	2005-03-18 21:13:21.000000000 -0500
> > @@ -41,7 +41,7 @@
> > #undef	ESD_DEBUG
> > 
> > #if	ESD_DEBUG
> > -#define	dprintf(...)	printf(__VA_ARGS__)
> > +#define	dprintf(...)	mp_msg(MSGT_AO, MSGL_DBG2,__VA_ARGS__)
> 
> What is the advantage of this change?  Debug output does not get
> translated anyway, so why use mp_msg?

So that stdout is not flooded.  We can easily modify mp_msg to keep
console clean and push text output elsewhere.  Printf should not be used
outside of mp_msg, IMO.

--Joey

-- 
Me: "Isn't Kennedy as real as Colonel Sanders?"
Chad: "... Which Kennedy?"