[MPlayer-dev-eng] [PATCH] YUV4MPEG2 mencoder output format

[Reimar Döffinger]

Hi,
On Sun, Jan 09, 2005 at 12:23:35PM +0100, Roine Gustafsson wrote:
> On Sunday, Jan 9, 2005, at 10:33 Europe/Stockholm, Reimar Döffinger 
> wrote:
> >Please fix/help us fix mplayer instead of duplicating code!
> >E.g. provide a proper bugreport of why you can't use -vo yuv4mpeg
> 
> The current -vo yuv4mpeg is part of mplayer, not mencoder. I can't use 
> any feature of mencoder and output in y4m.
> Here are some of my reasons for creating the mencoder muxer:
> 
> - Filters don't work correctly

Please be more precise, this should not be the case.

> - Only YV12 colorspace supported

I don't expect changing that to be more work than writing (and for us
maintaining!) a new muxer.

> - Automatic colorspace conversions break losslessness of y4m

mencoder should be doing them at exactly the same places. The (almost) only
difference between mencoder and mplayer is the code in mencoder.c and
mplayer.c...

> - Doesn't write colorspace information
> - Doesn't support pixel aspect ratios
> - Subject to frame droppings as it is part of a player

MPlayer will _never_ drop frames unless you tell it to! mencoder is the
one you have to bug hard not to drop frames.

> - Only output to file, not to a pipe

Huh? There is no difference between file and pipe on *nices

> - Annoyingly will open a dummy window if scripted, since it's part of a 
> player

Sorry??? I've never ever seen that, and I used it in scripts (see e.g.
mplmult.sh in the TOOLS dir)

> Apparently the vo-code has other qualities, like outputting subtitled 
> frames. It serves a different purpouse.
> 
> It's doing what I want; I'm simply offering it to you so I won't have 
> to re-patch my mencoder everytime I update it.

If you want to keep it like that... Then you will have to maintain it
and update it with every change to MPlayer. I am not ready to maintain
nearly the same code, that if there weren't bugs should provide the same
functionality.

Greetings,
Reimar Döffinger