[MPlayer-dev-eng] enhancement for yuv4mpeg output driver

[Trent Piepho]

On Thu, 20 Jan 2005, D Richard Felker III wrote:
> > Only if the number of bits in the mantissa is smaller than the number of bits
> > in the original denominator.  Secondly, you don't know the original bound on the
> > denominator.  
> 
> Smaller?? Nonsense, you have things totally backwards. I'm a

Editing error on my part, I meant to say "Not if" instead of "Only if".

> > Do a google search for mplayer and yuv4mpeg.  I think you'll find that
> > every single example of people ysing the yuv4mpeg output driver involves them
> > overriding the incorrect yuv4mpeg header mplayer generates with one that uses
> > a standard frame-rate.  I dare you to find a counter example.
> 
> Yes the current mplayer code is stupid and incorrect. Yours is just
> even more stupid.

So you don't deny that every single use of the yuv4mpeg device involves
overriding the broken frame rate with a different one?  And that this
different frame rate is always the one I make the yuv4mpeg device generate?

> I trust Michael, who said av_d2q works fine for him.

If you are going to say things like, "you must be doing something else wrong",
then please have the decency to actually look at what I'm doing and show that
it is wrong.  I gave you real examples of where av_d2q doesn't work, and
instead of acknowledging them, you just assume I'm an idiot and am doing
something wrong.

I posted the small patch that uses av_d2q like you asked, here are tiny 18kB
mpeg-es files for the NTSC rate codes, if you don't have any handy.
http://www.speakeasy.org/~xyzzy/download/rate1.mpv
http://www.speakeasy.org/~xyzzy/download/rate4.mpv
http://www.speakeasy.org/~xyzzy/download/rate7.mpv

Please apply the patch, run mplayer -vo yuv4mpeg on these files, and tell me
what happens.  Does it produce the correct output for you or not?  It doesn't
for me.