[MPlayer-dev-eng] [PATCH] vobsub: keep aspect ratio

[D Richard Felker III]

On Sat, Jan 22, 2005 at 06:23:32PM +0100, Csillag Kristof wrote:
> 2005-01-22, szo keltezéssel 12.18-kor D Richard Felker III ezt írta:
> > On Sat, Jan 22, 2005 at 11:54:26AM +0100, Guillaume Poirier wrote:
> > > Hi,
> > > 
> > > On Sat, 22 Jan 2005 06:39:01 +0100, Csillag Kristof <fenwick at freemail.hu> wrote:
> > > > What do you think? IMHO the subtitles look much better this way.
> > > > Shouldn't this be the default behavior?
> > > 
> > > You're probably right... but what happens if you use -vf expand to get
> > > for instance a 4:3 aspect ratio, which was what I used it the past to
> > > prevent vobsub distortion? (I must admit I haven't tested your patch
> > > yet).
> > 
> > If the patch uses width/height/d_width/d_heigh at the point where
> > subtitles are rendered, it will always do the correct thing whether or
> > not expand is used. If the patch uses the original movie aspect from
> > the file, it's horribly broken.
> If course the patch doesn't care about the movie aspect from the file;
> actually, mplayer's design architect is way smarter than that.
> 
> When subtitles are rendered, we are given two params, dxs and dys,
> which describe the size of the area we have now, _after_ all filtering &
> other operations. And we have the original frame size of the vobsub...
> So it would be really hard to get it wrong.
> 
> Anyway, see my screenshots posted earlier thie afternoon.

Great!
BTW could you make the same changes for rendering text subs? I wanted
to do that over a year ago but never figured out how. Right now, text
subs are rendered horribly wrong in any movie without square pixels.

Rich