[MPlayer-dev-eng] Re: [PATCH] vobsub: keep aspect ratio

[Csillag Kristof]

2005-01-22, szo keltezéssel 13.08-kor D Richard Felker III ezt írta:
> > 
> > When subtitles are rendered, we are given two params, dxs and dys,
> > which describe the size of the area we have now, _after_ all filtering &
> > other operations. And we have the original frame size of the vobsub...
> > So it would be really hard to get it wrong.
> > 
> > Anyway, see my screenshots posted earlier thie afternoon.
> 
> Great!
Well, not so great, since it still does not restore the proper aspect
rate.

When using the default method, the distortion factor will be

x_crop_factor * x_expand_factor
-------------------------------
y_crop_factor * y_expand_factor

and when using the new method (-spu-keep-aspect), the distortion factor
will be 

x_scale_factor
--------------
y_scale_factor

(The cropping/expanding/scaling can happen either during encoding,
either during playback time.)

  * * *

So, in other words, the old method is distorted by cropping/expanding,
and my new method is distorted by scaling. 

There should be a proper way; I will look at it again tomorrow.

 * * *

> BTW could you make the same changes for rendering text subs? I wanted
> to do that over a year ago but never figured out how. Right now, text
> subs are rendered horribly wrong in any movie without square pixels.
Well... really important exams are coming on tuesday (probably that's
why I'm doing this, anyway;), so I will not have much free time in the
coming few days... but I will look at it after I passed (or failed) my
exams.


	Kristof

-- 
Csillag Kristof <fenwick at freemail.hu>