[MPlayer-dev-eng] Re: [PATCH] vobsub: keep aspect ratio

[D Richard Felker III]

On Sun, Jan 23, 2005 at 02:36:20PM +0100, Csillag Kristof wrote:
> 2005-01-23, v keltezéssel 06.56-kor Csillag Kristof ezt írta:
> > 2005-01-22, szo keltezéssel 13.08-kor D Richard Felker III ezt írta:
> > > [...]
> > > Great!
> > Well, not so great, since it still does not restore the proper aspect
> > rate.
> > [...] the old method is distorted by cropping/expanding,
> > and my new method is distorted by scaling. 
> > 
> > There should be a proper way; I will look at it again tomorrow.
> The problem is that we render the subtitles _before_ the scaling up at
> playback time, and we have no idea about what size (or more importantly)
> aspect will it be scaled to. Of course the information is available
> somewhere in mplayer's dataspace, but the vobsub rendering module is
> obviously not aware of it.

Yes it is. The stage at which subs are renderred (either vf_expand or
the vo) knows the aspect from d_width/d_height. It just has to pass
the aspect info along to the sub rendering modules.

Rich