[MPlayer-dev-eng] [PATCH] libfaad update

[Aurelien Jacobs]

On Thu, 7 Jul 2005 00:53:21 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Wed, Jul 06, 2005 at 12:32:34PM +0200, Reimar Döffinger wrote:
> > despite the currently unclear license, I create a libfaad2 update
> > patch, e.g. playing AAC Plus streams is possible with this patch.
> 
> Does it work with AMD64?  Current libfaad apparently does not.

Indeed I also add this same experience of libfaad not working on
amd64. Now I wanted to test this patch and I first compiled a clean
MPlayer cvs, to discover that libfaad is now working !
(gcc-3.3.6, debian amd64)

> > Please test it as much as possible, so we can apply it as soon as we
> > resolved/decide what to do about their GPL-incompatible extra
> > clause.
> 
> What about using a CVS snapshot from before the licensing change?

That sounds reasonable.

> > Since it is so big, I put the patch here:
> > http://www.stud.uni-karlsruhe.de/~uvhe/faad_update.diff
> 
> Did you apply our stuff from local_changes.diff?

No, it's not applied ! But you can still apply it successfully on top
of this patch. With this patch and local_changes.diff applied, it
builds well and still works well on amd64.

Aurel