[MPlayer-dev-eng] [PATCH] libfaad update

[Diego Biurrun]

On Wed, Jul 06, 2005 at 12:32:34PM +0200, Reimar Döffinger wrote:
> despite the currently unclear license, I create a libfaad2 update patch,
> e.g. playing AAC Plus streams is possible with this patch.

Does it work with AMD64?  Current libfaad apparently does not.

> Please test it as much as possible, so we can apply it as soon as we
> resolved/decide what to do about their GPL-incompatible extra clause.

What about using a CVS snapshot from before the licensing change?

> Since it is so big, I put the patch here:
> http://www.stud.uni-karlsruhe.de/~uvhe/faad_update.diff

Did you apply our stuff from local_changes.diff?  This fails on PPC,
here is the output in configure.log:

cc     /tmp/mplayer-conf-3971-7871.c -o /tmp/mplayer-conf-20744-7871.o
-c -O4 -pipe -ffast-math -fomit-frame-pointer -std=gnu99 -D_GNU_SOURCE
-I/home/diego/src/mplayer/vanilla/libfaad2
In file included from
/home/diego/src/mplayer/vanilla/libfaad2/ps_dec.h:40,
                 from
/home/diego/src/mplayer/vanilla/libfaad2/sbr_dec.h:41,
                 from
/home/diego/src/mplayer/vanilla/libfaad2/structs.h:42,
                 from /tmp/mplayer-conf-3971-7871.c:43:
/home/diego/src/mplayer/vanilla/libfaad2/bits.h: In function
`flushbits_hcr':
/home/diego/src/mplayer/vanilla/libfaad2/bits.h:357: warning: comparison
is always false due to limited range of data type
In file included from /usr/include/stdlib.h:416,
                 from /tmp/mplayer-conf-3971-7871.c:45:
/usr/include/sys/types.h: At top level:
/usr/include/sys/types.h:191: error: conflicting types for `int8_t'
/home/diego/src/mplayer/vanilla/libfaad2/common.h:225: error: previous
declaration of `int8_t'
/usr/include/sys/types.h:193: error: conflicting types for `int32_t'
/home/diego/src/mplayer/vanilla/libfaad2/common.h:223: error: previous
declaration of `int32_t'

ldd /tmp/mplayer-conf-20744-7871.o
ldd: /tmp/mplayer-conf-20744-7871.o: No such file or directory

Result is: no (broken gcc)

Diego