[MPlayer-dev-eng] [PATCH] libfaad update

[Roberto Togni]

On Thu, 7 Jul 2005 09:07:12 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Thu, Jul 07, 2005 at 08:31:44AM +0200, Nico Sabbi wrote:
> > Diego Biurrun wrote:
> > 
> > >What do you suggest?  Using external libfaad like we did in the
past?
> > >
> > yes. If I remember correctly libfaad was imported at a time when one

> > time out of two it didn't even compile, now it's no more the case
> 
> True, it has matured a great deal.  Nevertheless our users now expect
us
> to be able to play AAC out-of-the-box ..

Technical answer: I'm for using external faad, unless our changes are
necessary to make it work with MPlayer on some systems.

"Legal" answer: they heve to give a clear answer on what they want to
do.  They can stay GPL (and then i see no reason to fork it), or they
can relicence it on different terms (if all contributors agree), but
they can't do both: imho their advertise clause is not GPL compatible,
so they can't say that the libray is GPL if they want to keep it.

Btw if we want to fork faad and continue developement outside official
repository, we should add it to ffmpeg (with --enable-gpl), not to
MPlayer.

Did MPlayer sent any faad patch upstream (something bigger than a few
line fix)? Do they require patch submitter to agree to some possible
relicence?

Ciao,
 Roberto