[MPlayer-dev-eng] PATCH to support theora-exp in mplayer
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon May 23 12:08:35 CEST 2005
Hi,
On Fri, May 13, 2005 at 09:13:17PM -0400, Timothy B. Terriberry wrote:
> Mimicing the recent changes to Vorbis demuxing, this version of the
> patch now passes the Theora headers appended to the BITMAPINFOHEADER.
> This should resolve the last outstanding issue that has been raised.
Without knowing the code...
> + fourcc theo,Thra
Good that there aren't more fourccs than necessary ;-) *SCNR*
> + nheaders = *ed+++1;
wtf? you want to win the obfuscated C contest? Far to go in that case,
but still nice try :-)
> if (context)
> {
> + theora_info_clear(&context->inf);
> + theora_comment_clear(&context->cc);
> free (context);
> sh->context = NULL;
> }
Mixing tabs and spaces...
> theora_comment cc;
> -
> +#if defined(HAVE_OGGTHEORA_EXP)
> + theora_setup_info *ts = NULL;
> + int pic_width;
> + int pic_height;
> +#endif
> +
> theora_info_init (&inf);
> theora_comment_init (&cc);
> -
> +
empty vs. whitespace-only lines cosmetics...
> +int ds_unget_packet(demux_stream_t *ds,unsigned char *start){
> + if(start<ds->buffer||start>&ds->buffer[ds->buffer_pos]){
> + return -1;
> + }
> + ds->buffer_pos=start-ds->buffer;
> + return 0;
> +}
> +
Please double-check this is correct and works as expected (esp. difficult
to see, since it is missing a doxygen-comment, too), it has a bad smell
to me...
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list