[MPlayer-dev-eng] PATCH to support theora-exp in mplayer
Rich Felker
dalias at aerifal.cx
Mon May 23 18:01:32 CEST 2005
On Mon, May 23, 2005 at 12:08:35PM +0200, Reimar Döffinger wrote:
> > +int ds_unget_packet(demux_stream_t *ds,unsigned char *start){
> > + if(start<ds->buffer||start>&ds->buffer[ds->buffer_pos]){
> > + return -1;
> > + }
> > + ds->buffer_pos=start-ds->buffer;
> > + return 0;
> > +}
> > +
>
> Please double-check this is correct and works as expected (esp. difficult
> to see, since it is missing a doxygen-comment, too), it has a bad smell
> to me...
Agree totally, this should be removed. Non-header packets before the
header packets are invalid anyway, so there's no reason to "unget"
them back into the demuxer.
Rich
More information about the MPlayer-dev-eng
mailing list