[MPlayer-dev-eng] [PATCH] OSD localization first try

[Diego Biurrun]

On Sun, Oct 23, 2005 at 11:16:37AM -0400, Rich Felker wrote:
> On Sun, Oct 23, 2005 at 03:22:45PM +0200, Paul TT wrote:
> > On Sun, 23 Oct 2005 03:29:35 +0200
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > > On Sat, Oct 22, 2005 at 03:49:50PM +0200, Paul TT wrote:
> > > > 
> > > > PS: note that this patch also resloves a bug about osd alignment
> > > > (bottom and top where wrong....)
> > > 
> > > Anyway, I think the current code is correct:
> > > 
> > >   if (osd_show_sub_alignment) {
> > >     snprintf(osd_text_tmp, 63, "Sub alignment: %s",
> > >       (sub_alignment == 2 ? "bottom" :
> > >       (sub_alignment == 1 ? "center" : "top")));
> > >     osd_show_sub_alignment--;
> > > 
> > > This agrees with the man page entry:
> > > 
> > >   -spualign <-1-2> (OSD only)
> > >     Specify  how  SPU  (DVD/VOBsub) subtitles should be aligned.
> > >       -1   original position
> > >        0   Align at top (default).
> > >        1   Align at center.
> > >        2   Align at bottom.
> > > 
> > > So what gives?
> > 
> > yes. you're right.
> > the code of mplayer.c is indeed right, i checked. it seems that the
> > wrong code is located in libvo/sub.c.....
> 
> This is nonsense. The original code before your patch was correct. Why
> do you claim it was wrong??

We've sorted this out on IRC.  The documentation was ambiguous and thus
it's hard to tell whether the code really implemented the expected
behavior or not.

Diego